Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to make the library compatible with Symfony 7
Lazy
implementation already used for theTranslator
class, to handle the incompatible return types and type hinted arguments.Translator::setLocale
returningvoid
(throwing\Symfony\Component\Translation\Exception\InvalidArgumentException
) instead ofbool
. As I have the feeling it's just a BC break? It's getting more and more quirky to keep supporting older versions (of Symfony). Symfony5.4
is the lowest LTS version atm, see https://symfony.com/releasesvoid
Thoughts?