-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return null instead of false #2340
Conversation
68374b3
to
c8b4628
Compare
Codecov Report
@@ Coverage Diff @@
## 3.x #2340 +/- ##
=============================================
+ Coverage 99.95% 100.00% +0.04%
=============================================
Files 882 886 +4
Lines 8525 9269 +744
=============================================
+ Hits 8521 9269 +748
+ Misses 4 0 -4
Continue to review full report at Codecov.
|
I like where this is going, |
This is the planned progression: strict mode becomes Actually with the default strict mode already in 3.0.0 you can't get |
Got it, that makes a lot of sense to me. Good to see this library turning away from PHP's error swallowing legacy swamp. |
This is hoping it will also evolve on PHP side because providing methods like So it will still need careful checking with dependent packages to validate we can keep it for the future stable release but I have good hope. |
7f46bf0
to
1f38f65
Compare
Use stronger typing and
null
instead offalse