-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
travisci and styleci configuration upgrade #1087
Conversation
Does changing the function type hints from Carbon to self affect code editors offering type hints? I seem to remember this being done and then reverted for some reason. (Maybe I am thinking of the return types) |
This would mean IDE bug. With eq(self $dt) PHPStorm says me eq needs a Carbon instance. If someone complaints his IDE does not support, I would suggest to report an issue to the IDE owner. |
@briannesbitt: I cannot find any history in I have tried PHPstorm and vscode; all autocomplete are working... |
vscode and PHPStorm have the same autocomplete engine so it's not so objective XD |
But even if it would fail, it should not be taken into account. IDE does not support all magic methods properly but it's not a reason to avoid them. IDE plugins have to evolve according to new features not the opposite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for me.
@@ -21,7 +21,7 @@ | |||
'hour' => '1 час|:count часа', | |||
'h' => '1 час|:count часа', | |||
'minute' => '1 минута|:count минути', | |||
'm' => '1 минута|:count минути', | |||
'min' => '1 минута|:count минути', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be committed in an other PR I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I also wanted to solve phpcs errors.
Ya, looks like I was thinking of the return value. (static|Carbon|self) and working nicely with phpdoc. I think I am good to go here. |
Why it is not merged yet? When it will be? Just want to know because I waiting to rebase my PRs. |
Hi @Ovsyanka this PR is only 2-hours old and it's a big one. Double-checking it will avoid you to rebase multiple times ;) |
Before we continue resolving all the issues and PR's, travisci and styleci should return successful builds. Based on that all this files were modified, which don't break anything.