Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travisci and styleci configuration upgrade #1087

Merged
merged 17 commits into from
Feb 13, 2018

Conversation

Glavic
Copy link
Collaborator

@Glavic Glavic commented Feb 13, 2018

Before we continue resolving all the issues and PR's, travisci and styleci should return successful builds. Based on that all this files were modified, which don't break anything.

@briannesbitt
Copy link
Owner

Does changing the function type hints from Carbon to self affect code editors offering type hints? I seem to remember this being done and then reverted for some reason. (Maybe I am thinking of the return types)

@kylekatarnls
Copy link
Collaborator

This would mean IDE bug. With eq(self $dt) PHPStorm says me eq needs a Carbon instance.

If someone complaints his IDE does not support, I would suggest to report an issue to the IDE owner.

@Glavic
Copy link
Collaborator Author

Glavic commented Feb 13, 2018

@briannesbitt: I cannot find any history in src/Carbon/Carbon.php that contains self $dt, so this was probably never implemented?

I have tried PHPstorm and vscode; all autocomplete are working...

phpstorm

vscode

@Glavic Glavic mentioned this pull request Feb 13, 2018
@kylekatarnls
Copy link
Collaborator

vscode and PHPStorm have the same autocomplete engine so it's not so objective XD

@kylekatarnls
Copy link
Collaborator

But even if it would fail, it should not be taken into account. IDE does not support all magic methods properly but it's not a reason to avoid them. IDE plugins have to evolve according to new features not the opposite.

Copy link
Collaborator

@kylekatarnls kylekatarnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me.

@@ -21,7 +21,7 @@
'hour' => '1 час|:count часа',
'h' => '1 час|:count часа',
'minute' => '1 минута|:count минути',
'm' => '1 минута|:count минути',
'min' => '1 минута|:count минути',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be committed in an other PR I think.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I also wanted to solve phpcs errors.

@briannesbitt
Copy link
Owner

Ya, looks like I was thinking of the return value. (static|Carbon|self) and working nicely with phpdoc. I think I am good to go here.

@Ovsyanka
Copy link
Contributor

Why it is not merged yet? When it will be? Just want to know because I waiting to rebase my PRs.

@kylekatarnls
Copy link
Collaborator

Hi @Ovsyanka this PR is only 2-hours old and it's a big one. Double-checking it will avoid you to rebase multiple times ;)

@briannesbitt briannesbitt merged commit cc6e045 into briannesbitt:master Feb 13, 2018
@Glavic Glavic deleted the travis_styleci branch February 14, 2018 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants