Add CentOS on Travis CI. #989

junaruga · 2018-06-28T17:27:29Z

Related: #988 .

junaruga · 2018-06-28T17:29:10Z

spec/mysql2/client_spec.rb

@@ -135,15 +136,22 @@ def connect(*args)

    # You may need to adjust the lines below to match your SSL certificate paths
    ssl_client = nil
+    option_overrides = {


This modification is to pass the test on the CentOS environment that does not have /etc/mysql/*.pem files.

junaruga · 2018-06-28T17:29:44Z

spec/mysql2/result_spec.rb

@@ -164,7 +164,7 @@
      expect do
        res.each_with_index do |_, i|
          # Exhaust the first result packet then trigger a timeout
-          sleep 2 if i > 0 && i % 1000 == 0
+          sleep 4 if i > 0 && i % 1000 == 0


This modification is to pass the test on CentOS.

junaruga · 2018-06-28T17:31:53Z

spec/mysql2/client_spec.rb

@@ -1,5 +1,6 @@
 require 'spec_helper'

+# rubocop:disable Metrics/BlockLength


By below modification, the length of the block is more than the limitation.
As I was not sure how to fix, I added this ignored line.

See file .rubocop_todo.yml.

But you may be right that the better approach is not to globally increase the limit, but to ignore it for this file and have a more sensible limit apply everywhere else.

Okay, I will change current limit 850 to 860 to prevent below situation.

spec/mysql2/client_spec.rb:3:1: C: Metrics/BlockLength: Block has too many lines. [851/850]

junaruga · 2018-06-28T17:34:43Z

.travis.yml

@@ -73,6 +74,12 @@ matrix:
      addons:
        hosts:
          - mysql2gem.example.com
+    - rvm: 2.4


This part is a little bit tricky. Actually the tested Ruby on CentOS is not Ruby 2.4 but default installed Ruby on CentOS. But I was not sure how to update rvm: foo to show rvm is not used directly on Travis.

simi · 2018-06-28T17:36:45Z

.travis_centos.sh

+sh .travis_setup_centos.sh
+
+# To avoid install error.
+sed -i '/eventmachine/d' Gemfile


Why is this needed? Can't we fix the install error?

Thanks for the comment.
It is to avoid install error by bundle install on CentOS.
But let me check again to fix it.

The reason of the error is just because g++ command was not installed on the environment.

I fixed it and rebased.

sodabrew · 2018-07-04T14:15:47Z

.travis.yml

@@ -73,6 +74,12 @@ matrix:
      addons:
        hosts:
          - mysql2gem.example.com
+    - rvm: 2.4
+      # Mark


Who is Mark?

"Mark" is not people's name in this case. I want to describe env: DOCKER=centos is just used to identify this test case from Travis test page. But I am going to remove the line.

sodabrew · 2018-07-04T14:18:38Z

.travis_Dockerfile_centos

@@ -0,0 +1,6 @@
+FROM centos


Suggest to use tagged version with centos:7.

All right. I will change it to centos:7.

sodabrew · 2018-07-04T14:19:56Z

.travis_centos.sh

+set -eux
+
+# Install dependency packages and start mysqld service.
+sh .travis_setup_centos.sh


I think this should go into the Dockerfile, so that you can benefit from layer caching of these dependencies.

All right. Let me move the logic to the Dockefile.

There is a problem to move the .travis_setup_centos.sh to Dockerfile RUN (that is executed on docker build's timing).
We can not start mysqld daemon service in the process of docker build. (Can not access the service).
So, I moved only the part to install dependency to the Dockerfile RUN part.
I added the modification as another commit to see the change easily for now.
How?
Thank you for the checking.

sodabrew · 2018-07-04T14:20:48Z

spec/mysql2/client_spec.rb

@@ -1,5 +1,6 @@
 require 'spec_helper'

+# rubocop:disable Metrics/BlockLength


See file .rubocop_todo.yml.

But you may be right that the better approach is not to globally increase the limit, but to ignore it for this file and have a more sensible limit apply everywhere else.

junaruga · 2018-07-30T09:51:07Z

@sodabrew thank you for the review! I am sorry I did not noticed until now. I will check those later.

junaruga · 2018-07-30T17:54:23Z

@sodabrew I modified it!

sodabrew · 2018-07-30T18:44:27Z

Looks good to me! Are you ready for merge, or still hacking on this PR?

junaruga · 2018-07-30T20:00:39Z

@sodabrew I am ready for merge! I did squash the 2 commits to 1 commit now.

junaruga · 2018-07-31T09:41:27Z

Thank you! 😄

* upstream/master: Expose windows client authentication (brianmario#1018) Fix code snippet (brianmario#1002) Add CentOS on Travis CI. (brianmario#989) Bump version to 0.5.2 Travis apt-get update for MySQL 5.5 install Updating the mysql2_mysql_enc_to_rb conversion table to 8.0 List (brianmario#976) Add default-libmysqlclient-dev to the likely packages list Bump version to 0.5.1 Use the prepared statement performance schema if available (brianmario#960) README mysql2 0.5.x works with Rails 5.0.7, 5.1.6, and higher README be sure to read about the known limitations of prepared statements Add missing FREE_BINDS to prepared statement streaming error case (brianmario#958) Fix with --with-mysql-dir (brianmario#952) Prevent command out of sync errors with Prepared Statements (brianmario#958)

junaruga commented Jun 28, 2018

View reviewed changes

simi reviewed Jun 28, 2018

View reviewed changes

junaruga force-pushed the feature/travis-centos branch from 32118f0 to 1c126cc Compare June 29, 2018 08:45

sodabrew requested changes Jul 4, 2018

View reviewed changes

sodabrew added this to the 0.5.3 milestone Jul 4, 2018

junaruga force-pushed the feature/travis-centos branch 2 times, most recently from 9524d5a to d697180 Compare July 30, 2018 16:37

sodabrew approved these changes Jul 30, 2018

View reviewed changes

Add CentOS on Travis CI.

f72a894

junaruga force-pushed the feature/travis-centos branch from b3da64b to f72a894 Compare July 30, 2018 19:46

sodabrew merged commit bc73887 into brianmario:master Jul 30, 2018

junaruga deleted the feature/travis-centos branch July 31, 2018 09:41

sodabrew mentioned this pull request Jul 31, 2018

Adding CentOS to Travics CI #988

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CentOS on Travis CI. #989

Add CentOS on Travis CI. #989

junaruga commented Jun 28, 2018

junaruga Jun 28, 2018

junaruga Jun 28, 2018

junaruga Jun 28, 2018

sodabrew Jul 4, 2018

junaruga Jul 30, 2018

junaruga Jun 28, 2018

simi Jun 28, 2018

junaruga Jun 28, 2018

junaruga Jun 28, 2018

junaruga Jun 29, 2018

sodabrew Jul 4, 2018

junaruga Jul 30, 2018

sodabrew Jul 4, 2018

junaruga Jul 30, 2018

sodabrew Jul 4, 2018

junaruga Jul 30, 2018

junaruga Jul 30, 2018 •

edited

Loading

sodabrew Jul 4, 2018

junaruga commented Jul 30, 2018

junaruga commented Jul 30, 2018

sodabrew commented Jul 30, 2018

junaruga commented Jul 30, 2018

junaruga commented Jul 31, 2018

		@@ -1,5 +1,6 @@
		require 'spec_helper'

		# rubocop:disable Metrics/BlockLength

Add CentOS on Travis CI. #989

Add CentOS on Travis CI. #989

Conversation

junaruga commented Jun 28, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

junaruga Jul 30, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

junaruga commented Jul 30, 2018

junaruga commented Jul 30, 2018

sodabrew commented Jul 30, 2018

junaruga commented Jul 30, 2018

junaruga commented Jul 31, 2018

junaruga Jul 30, 2018 •

edited

Loading