Expose the mysql_set_server_option:
#943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use case: I'd like to be able to do multiple statements query without having to reconnect to the db first. Without this feature, if I want to do a multi statement query **after** the connection is established without the `MULTI_STATEMENTS` flag, I'd have to set the flag on the connection and reconnect - One of the main motivation for this is because Rails is now inserting fixtures inside a multi-statements query. We used the workaround I described above, but it would be great if we could use the mysql function mysql_set_server_option . For more context [Ref](rails/rails#31422 (comment)) - Ref https://dev.mysql.com/doc/refman/5.5/en/mysql-set-server-option.html
|
The build is failing because of rubocop (I added more tests thus the |
|
Looks awesome. Thanks for this contribution! Merging now! |
|
Thanks a lot for the quick merge, appreciate ❤️ |
sodabrew
added a commit
to sodabrew/mysql2
that referenced
this pull request
Mar 19, 2018
sodabrew
added a commit
to sodabrew/mysql2
that referenced
this pull request
Mar 20, 2018
This was referenced Mar 21, 2018
jeremy
added a commit
to jeremy/mysql2
that referenced
this pull request
Mar 21, 2018
* master: (21 commits) Bump version to 0.5.0 README note that MariaDB 10.3 and Ruby 2.6 are supported Initialize params_enc variable to resolve a warning Travis CI add MariaDB 10.3 Travis CI add Ruby 2.6 Use a local scope to avoid leaking the temporary variable for bind_count Revert "Layout/IndentHeredoc" Bump RuboCop limits for spec file length Style nit fix for brianmario#943 Use a typedef my_bool to improve compatibility across MySQL versions Revert "Use `bool` instead of `my_bool` which has been removed since MySQL 8.0.1 (brianmario#840)" Style nit for brianmario#943 Expose the `mysql_set_server_option`: (brianmario#943) Update usage section of README.md (brianmario#939) Travis CI should run MySQL 5.5 tests on Trusty Looks like Windows Ruby 2.0 still has the buggy mkmf Use CLIENT_CONNECT_ATTRS flag to test the connection attributes feature README note that MariaDB 10.2 is supported Travis CI drop tests for MySQL 5.1 on Ubuntu Precise Fix Ruby 2.4 on Appveyor ...
This was referenced Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the
mysql_set_server_option:MULTI_STATEMENTSflag, I'd have to set the flag on the connection and reconnect