Call BigDecimal(num) instead of BigDecimal.new(num) #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out I was chasing a NULL pointer on cBigDecimal from statement.c when I removed the class lookup from result.c, extern meant the compiler did not flag an uninitialized value.
|
Thanks for the fix. I have verified It would be appreciated the new version of mysql2 gem released to support Ruby 2.5 which is scheduled to release on 12/25. Thanks again for the fix. |
|
I can backport the deprecation warning fix to 0.4.x as well in January, there no other issue on Ruby 2.5 besides this warning.
|
|
Sounds good. 0.4.x including this fix is fine for me. |
This was referenced Mar 21, 2018
@sodabrew it seems the above has not happened yet |
jonhinson
pushed a commit
to jonhinson/mysql2
that referenced
this pull request
Jan 18, 2020
Call BigDecimal(num) instead of BigDecimal.new(num) to be ready for this deprecation in Ruby 2.6, and eliminate a deprecation warning now. Reduce the number of extern classes - while developing this change, I was chasing a NULL pointer on cBigDecimal from statement.c because I removed the class lookup from result.c, but extern meant the compiler did not flag it as an uninitialized value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #925