Drop 1.9.3 support #913
Drop 1.9.3 support #913
Conversation
ext/mysql2/client.h
Outdated
| @@ -1,6 +1,8 @@ | |||
| #ifndef MYSQL2_CLIENT_H | |||
| #define MYSQL2_CLIENT_H | |||
|
|
|||
| // rb_thread_call_without_gvl was added in 2.0.0. See: | |||
| // https://github.com/ruby/ruby/commit/c51a826. | |||
There was a problem hiding this comment.
Could be removed? Or is it needed for RBX?
|
Can remove |
|
Duh, good eye. Removed some more things.
…On Tue, Nov 28, 2017 at 8:50 PM, Aaron Stone ***@***.***> wrote:
Can remove if Thread.respond_to?(:handle_interrupt) blocks in client.rb
and statement.rb, too.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#913 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABdsPJ3Mq0VnI0SezFVs1SKXzLLyyKW2ks5s7LhIgaJpZM4QuSDn>
.
|
|
This matches up with all the changes I was testing locally, thank you! Even RHSCL Ruby 1.9.3 ended over a year ago: https://access.redhat.com/support/policy/updates/rhscl/ (search for ruby) Unfortunately Ubuntu Trusty with its ridiculous Ruby 1.9.3 default is supported as a distribution until 2019, oh well. |
|
Yikes :( |
|
I noticed a few more |
|
Just saw one, done. |
|
Interesting that RHSCL also dropped support for 2.0 at the same time they dropped 1.9. Shall we keep this train rolling? |
|
Just a quick inventory suggests that only Ubuntu Trusty and Debian Wheezy are holding out at 1.9.3/2.0.0. Wheezy EOL is May 2018, and Trusty EOL is April 2019 (ugh, as mentioned, but also by that time will be two full LTS releases behind, so I'm less worried). Older Mac OS X is at Ruby 2.0, Debian Jessie is on Ruby 2.1, and meanwhile everyone else has congregated at Ruby 2.3 now: Debian Squeeze and Buster, Ubuntu Xenial and (probably) Bionic, OS X High Sierra, and RHSCL 7. |
* master: GitHub is HTTPS by default (brianmario#922) Fix wrong value of type YEAR on big endian environment. (brianmario#921) Avoid 0 byte allocation call when statement takes no parameters Small spec improvement for RSpec style Travis CI for Mac OS X builds use the same steps again More specific exception classes (brianmario#911) Travis CI matrix add Ruby 2.5 and switch Mac OS X to Ruby 2.3 (ala High Sierra) README text for query options on Statement#execute Accept query options on Statement#execute (brianmario#912) Drop 1.9.3 support (brianmario#913)
@sodabrew I might've missed something, but doesn't look like there's a huge upshot to doing this (at least not until we're ready to drop 2.0.0).