Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid modifying frozen string literals #1364

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Avoid modifying frozen string literals #1364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/mysql2/extconf.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def add_ssl_defines(header)
/usr/local/opt/mysql@*
/usr/local/opt/mysql-client
/usr/local/opt/mysql-client@*
].map { |dir| dir << '/bin' }
].map { |dir| "#{dir}/bin" }

# For those without HOMEBREW_ROOT in PATH
dirs << "#{ENV['HOMEBREW_ROOT']}/bin" if ENV['HOMEBREW_ROOT']
Expand Down
2 changes: 1 addition & 1 deletion spec/mysql2/client_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,7 +886,7 @@ def run_gc
end

it "should carry over the original string's encoding" do
str = "abc'def\"ghi\0jkl%mno"
str = "abc'def\"ghi\0jkl%mno".dup
escaped = Mysql2::Client.escape(str)
expect(escaped.encoding).to eql(str.encoding)

Expand Down