Add an option to use certifications generated from localhost. #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junaruga
force-pushed
the
wip/cert-host-custom
branch
from
108bde8 to
fc91c93
Compare
|
Rebasing this PR on the latest master branch. However, the #1293 is a higher priority for me. :) |
|
Since #1293 landed, is this PR still needed to build on it or close it out? |
junaruga
force-pushed
the
wip/cert-host-custom
branch
from
fc91c93 to
a1da82d
Compare
I think this PR is still needed. I rebased it on the latest master branch. In Fedora's building environment, we cannot edit the /etc/hosts file to add the "mysql2gem.example.com". So, in the |
In the Fedora project, we are running the mysql2 tests on the build environment with a user permission, without root permission and without `sudo`. In this case, we couldn't set up the custom domain "mysql2gem.example.com" required to run SSL tests. This feature to create a set of the certifications from the localhost gives an option to run the SSL tests executed in the environment. How to generate the certificaton files: ``` $ cd spec/ssl/ $ bash gen_certs.sh ``` The files are generated in the `spec/ssl/<host name>`. Added the new files generated from the domain localhost in the `spec/ssl/localhost`. How to use: ``` $ TEST_RUBY_MYSQL2_SSL_CERT_HOST=localhost \ bundle exec rake spec ```
junaruga
force-pushed
the
wip/cert-host-custom
branch
from
a1da82d to
99623e7
Compare
|
Do you have any concerns or needs about the PR? If you have those, I am happy to think an alternative way again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Fedora project, we are running the mysql2 tests on the build environment with a user permission, without root permission and without
sudo.In this case, we couldn't set up the custom domain "mysql2gem.example.com" required to run SSL tests. This feature to create a set of the certifications from the localhost gives an option to run the SSL tests executed in the environment.
How to generate the certificaton files:
The files are generated in the
spec/ssl/<host name>. Added the new files generated from the domain localhost in thespec/ssl/localhost.How to use:
The implementation is similar with #1293 .