Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefine T_DATA allocators for Ruby 3.2 compatibility #1236

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

casperisfine
Copy link
Contributor

@casperisfine casperisfine commented Jan 17, 2022

Ref: https://bugs.ruby-lang.org/issues/18007

cc @tenderlove

lib/mysql2/em.rb:17: warning: undefining the allocator of T_DATA class Mysql2::Result
spec/mysql2/statement_spec.rb:56: warning: undefining the allocator of T_DATA class Mysql2::Statement

@casperisfine casperisfine force-pushed the ruby-3.2-t-data-allocator branch from 8f0f46d to 87b3caf Compare January 17, 2022 15:39
@casperisfine casperisfine force-pushed the ruby-3.2-t-data-allocator branch from 87b3caf to 6c4e8be Compare January 17, 2022 15:48
@sodabrew
Copy link
Collaborator

sodabrew commented Jan 17, 2022

This appears to be fully backwards-compatible to earlier versions of Ruby as well?

LGTM, can merge today if you don't have any further changes to propose.

@casperisfine
Copy link
Contributor Author

This appears to be fully backwards-compatible to earlier versions of Ruby as well?

Yes, this isn't a new API, it just start to be slowly enforced.

if you don't have any further changes to propose.

Nope all good for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants