Support ruby GC compaction #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatkodima
force-pushed
the
gc-compaction
branch
from
7d81704 to
b4c1a05
Compare
|
Thank you very much for this! I will read up on compaction to learn more about it! Very likely I want to delay landing this until after the pending 0.5.x release so that there's a new stable version folks could fall back to in case of any instability caused by this change. |
|
@tenderlove This looks good to me! Any review notes at your end? |
|
Sorry about the very long delay. Would you mind rebasing since merging the #1284 made some minor conflicting changes? (If you don't have time I'll swing back to this and adjust in a fixit commit.) |
fatkodima
force-pushed
the
gc-compaction
branch
from
b4c1a05 to
8a83482
Compare
|
@sodabrew Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruby 2.7+ introduced GC compaction via
GC.compact. This PR helps this gem to be compaction friendly.