Can't enable SSL with MariaDB driver library. (#1182) #1183
Conversation
|
Thanks for the PR. Could you add new CI case for mysql-8.0 server and mariadb client? |
|
@vakuum I tried to create the commit to create DB server: MySQL, DB client: MariaDB #1186 . You can pick up if you like. I think the new CI case could create |
|
@vakuum Thanks for the work! I am sorry. Could you remove the 2nd commit? I am sorry. Because I got a feedback that it is not certain if we support the new case of the DB server (MySQL) + DB client (MariaDB) by adding the CI case. #1186 (comment) . And right now our Travis CI has MariaDB (server and client) cases. But the macro So, I think the right thing about the CI, is to update the one of the Travis MariaDB cases by enabling |
vakuum
force-pushed
the
master
branch
2 times, most recently
from
17ef695 to
2d3070a
Compare
|
Could you add my another commit to this PR? #1182 (comment) . |
| @@ -31,7 +31,7 @@ jobs: | |||
| - {os: ubuntu-16.04, ruby: 2.4, db: mariadb10.0, allow-failure: true} | |||
| # Comment out due to ci/setup.sh stucking. | |||
| # - {os: ubuntu-18.04, ruby: 2.4, db: mariadb10.1} | |||
| # `service mysql restart` fails. | |||
| # Allow failure due to the issue #965, #1165. | |||
Add tests to verify the following commmit. Can't enable SSL with MariaDB driver library.
* Relax the matching condition.
It's better to verify a warning by checking stderr.
But for now, just relax the matching condition, due to complex conditions.
```
expect do
new_client(options)
end.to_not output.to_stderr
```
* Change pending to skip in SSL tests.
The skip method is right in this context.
Because the pending method requires the test to fail.
But in some cases the test passes.
|
@junaruga: Is there any plan to merge this PR? |
|
@vakuum Sorry I do not have a permission to merge a PR on this repository. I am just a contributor on this repo. |
|
@vakuum if you want a new mysql2 gem including this PR now, I can recommend a way to create a releasing branch including this PR's commits on your forked repository, then run |
|
Sorry for the delay to review, this is a great PR, thank you @vakuum ! |
Please see #1182 for details.