Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found an random SEGV in mysql2 0.5.3, such as:
(this log is token from CircleCI)
In
rb_mysql_query()
, the raw pointer of the sql string is extracted,and it is passed to
do_send_query()
viaargs
.do_send_query()
internally releases the GVL, then ruby might do GCin the function.
Then, the sql string may be GC'ed, and causes SEGV.
Therefore, should guard the sql string until
do_send_query()
ends.