Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test_files (i.e. specs, examples) from gem #1060

Closed
wants to merge 1 commit into from
Closed

Remove test_files (i.e. specs, examples) from gem #1060

wants to merge 1 commit into from

Conversation

nbeyer
Copy link

@nbeyer nbeyer commented Aug 8, 2019

I'd like to propose removing the RSpecs and Examples from the packaged gem that's distributed. There doesn't seem to be any practical use of these files within a release version of the gem file. Another set of "test" files, benchmarks, is already not included. The benefit of removing these files would be a reduced gem file size as well as eliminating false positive vulnerabilities from security scanners (the test files include private certificates).

I'd like to propose removing the RSpecs and Examples from the packaged gem that's distributed. There doesn't seem to be any practical use of these files within a release version of the gem file. Another set of "test" files, benchmarks, is already not included. The benefit of removing these files would be a reduced gem file size as well as eliminating false positive vulnerabilities from security scanners (the test files include private certificates).
@sodabrew
Copy link
Collaborator

sodabrew commented Oct 2, 2019

Resolved by #1044

@sodabrew sodabrew closed this Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants