Skip to content

Commit

Permalink
GitHub Actions: Remove allow-failure on Fedora MariaDB cases.
Browse files Browse the repository at this point in the history
The tests pass now.

Still keep allow-failure on macOS MariaDB case due to test failures that rarely happens.
  • Loading branch information
junaruga committed Apr 16, 2021
1 parent 4a47e8a commit 33713f9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 9 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,8 @@ jobs:
# db: A DB's brew package name in macOS case.
# Set a name "db: '[email protected]'" when using an old version.
# MariaDB lastet version
# Allow failure due to the following test failures.
# https://github.com/brianmario/mysql2/issues/965
# https://github.com/brianmario/mysql2/issues/1152
# Allow failure due to the following test failures that rarely happens.
# https://github.com/brianmario/mysql2/issues/1194
- {os: macos-latest, ruby: 2.4, db: mariadb, allow-failure: true}
# MySQL latest version
# Allow failure due to the issue #1165.
Expand Down
8 changes: 2 additions & 6 deletions .github/workflows/container.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,9 @@ jobs:
# CentOS 7 system Ruby is the fixed version 2.0.0.
- {distro: centos, image: 'centos:7', name_extra: 'ruby 2.0.0'}
# Fedora latest stable version
# Allow failure due to the following test failures.
# https://github.com/brianmario/mysql2/issues/965
- {distro: fedora, image: 'fedora:latest', allow-failure: true}
- {distro: fedora, image: 'fedora:latest'}
# Fedora development version
# Allow failure due to the following test failures.
# https://github.com/brianmario/mysql2/issues/1152
- {distro: fedora, image: 'fedora:rawhide', allow-failure: true}
- {distro: fedora, image: 'fedora:rawhide'}
# On the fail-fast: true, it cancels all in-progress jobs
# if any matrix job fails unlike Travis fast_finish.
fail-fast: false
Expand Down

0 comments on commit 33713f9

Please sign in to comment.