Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building OpticSim with an old version of Julia #33

Open
arbenede opened this issue May 23, 2024 · 3 comments
Open

Building OpticSim with an old version of Julia #33

arbenede opened this issue May 23, 2024 · 3 comments

Comments

@arbenede
Copy link

I see that it is not possible to build OpticSim with the current release of Julia. Since development of this package has paused, I think that it would be very useful to have the sequence of steps needed to build and run OpticSim with an old release of Julia. I tried Julia 1.8 but still got errors. I guess that this might required downgrading some packages to get the ecosystem to the state it was when OpticSim was running.

@brianguenter
Copy link
Owner

brianguenter commented May 23, 2024

My guess is that the primary problem is Makie. Sometime long ago the API changed and I never had enough free time to understand how to change our code to match.

It looks like the current version of the code has been modified in an attempt to make it work with the new version of Makie, but the attempt was not successful. So the code is broken, even if you use an older version of Julia.

Here is a typical example from Visualization.jl. Do you know how the new scene layout stuff works in Makie? If you do take a look at that piece of code and see if you can figure out how to fix it. It's just stuff to set up Makie windows, nothing specialized to optics. If you'll help I'll take a shot at making the code work with the latest version of Julia.

@arbenede
Copy link
Author

I was eventually able to build OpticSim under Julia 1.10 just by running the install process and build process multiple times, however I see the problem with Makie that you mention. By the way, the link to Visualization.jl that you provide above points to this page, probably not what you intended... I have never used Makie, however I will try to fix these errors and submit a PR.

@brianguenter
Copy link
Owner

Sounds good. Don't hesitate to contact me if you run into problems. It's been a minute since I looked at the code but I still have a good understanding of how it all works.

Here's the link I intended to include.

function scene(resolution = (1000, 1000))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants