fix decoding of response from HNPWA API so it is read as UTF-8 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the build didn't actually break but stopped for some reason. Maybe needs further investigation there? |
|
Oops, sorry i missed this! Thanks so much for the fix :) Shipping this as part of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst making use of the package, I had noticed that certain parts of the text weren't appearing properly.
For example, item 20043410 has a title of The Boring Company will develop an underground “people mover” for Las Vegas. However, the package returns the title as The Boring Company will develop an underground “people moverâ€� for Las Vegas. Looking at the response headers, it can be seen that the charset isn't being set. As such the fix here is to decode the response body in bytes UTF-8 as per the discussion here