-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiny error propagation fix, no accompanying test :( #1
Conversation
I like it! I think that's a nice idea. Much better to only have to handle the 'error' event at one level (Client or Connection), and not having to do this is a win:
I would like to see some tests for this eventually...how about something like this?
That being said, I've not tested the error propagation from connection to client either I don't believe. I'll go ahead and merge your changes here in a minute. |
Didn't realize it'd be so easy to test. Nice! |
Fail if pgsql returned row is bigger than limit
Emit 'close' events when query completes
Demonstrate that pg-pool exports Pool constructor
Support usage of relative urls to set database on the default host
Hey, I'm new to the whole fork/pull request thing. I'm more trying this out than considering this a SRS FEATURE that YOU MUST ACCEPT. Am I supposed to do this in a separate branch?
Anyway, for some reason I keep getting a broken pipe which was killing my connection. Three lines to the rescue.