Upgrade to test on node 10

[brianc]

• Upgrade travis to test with node 10 instead of node 9.
• Upgrade some dev dependencies which npm identified had security vulnerabilities. Not a huge deal since they're dev deps, but it's good hygiene.
• check in package-lock.json generated by newer version of npm.
• consume from socket in timeout tests or the server will never close them, and the tests will hang.
• fix a test which was using both done and returning a promise.
• remove --no-exit from mocha, which ironically I originally added many moons ago but has now become the default behavior.

[brianc]

apparently error.errno and error.code are platform specific for socket errors? The tests pass for me on os x but fail in travis on ubuntu? 🤷‍♂️

[charmander]

Is allowing any error that doesn’t have an errno to pass the test okay?

[brianc]

I think so - what do you think? The error numbers seem platform specific (weirdly) and the error messages changed between node versions. I suppose i could check process.version and assert differently

…

On Fri, Dec 14, 2018 at 9:48 PM Charmander ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In test/error-handling.js <#114 (comment)>: > @@ -154,11 +154,15 @@ describe('pool error handling', function () { const pool = new Pool({ max: 1, port: closeServer.address().port }) pool.connect((err) => { expect(err).to.be.an(Error) - expect(err.message).to.be('Connection terminated unexpectedly') + if (err.errno) { Is allowing any error that doesn’t have an errno to pass the test okay? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#114 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADDoRiB90WD77UXGcUsSKPdqfn2vcjUks5u5HEEgaJpZM4ZURC6> .

[charmander]

It’s probably fine to leave until the problematic version of Node goes EOL. :)