Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd): set kinesis metadata in tap CLI #293

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

shellcromancer
Copy link
Contributor

Description

This reduces inconsistency between the message payloads in production Kinesis streams and streams read locally with substation tap by setting the metadata in the CLI.

Motivation and Context

Without this change transforms relying on the metadata would be fail or be incorrect.

How Has This Been Tested?

I tapped production stream and ensured the correct metadata was set.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@shellcromancer shellcromancer requested a review from a team as a code owner January 16, 2025 22:59
@shellcromancer shellcromancer merged commit 4156385 into main Jan 17, 2025
7 checks passed
@shellcromancer shellcromancer deleted the dstinson-diess/feat/set-meta-in-tap branch January 17, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants