Disable jdbc4ConnectionTest when connectionTestQuery is set #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettwooldridge
added a commit
that referenced
this pull request
Mar 24, 2014
|
Mreged into |
brettwooldridge
added a commit
that referenced
this pull request
Mar 26, 2014
* dev: (77 commits) Unwrap DataSource test. Discourage users from turning on metrics until they do something useful. Add idle fill test. Reduce the number of filler threads ... 8 threads is too many on a hyper threaded 4-core CPU. Start implementing [optional] metrics for HikariCP. Additional connection tests. Add provided dependency on coda hale metrics. Merged #48 fix connectionTest validation Change defaults. Default minIdle the same as maxPoolSize. Split out stateless utility functions to reduce the weight of the HikariPool class (increases readability). Rename idleConnectionBag to connectionBag. Change connectionTimeout minimum to 250ms. Fix timing edge case in test. Check validation error Improve warnings for invalid configuration Use the DriverManager to create connections. Update changes.log. Update changes.log. Remove deprecated calls from tests, fix test conditions for new background fill behavior. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation says that
jdbc4ConnectionTestis mutually exclusive with theconnectionTestQueryproperty; this commit makes that happen.