fix fast statement list overflow inconsistency #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged into dev. |
|
@brettwooldridge Could you let me know when a release is available with this fix? I want to release a new version of http://activate-framework.org using HikariCP instead of BoneCP. |
brettwooldridge
added a commit
that referenced
this pull request
Feb 16, 2014
brettwooldridge
added a commit
that referenced
this pull request
Feb 18, 2014
* dev: (22 commits) Javadoc, renaming, and cleanup. Fix FastStatementList unit test failure. Slightly cleaner fix for issue #35 javadoc. Change default size from 16 to 32, and change growth factor from 4x to 2x. Add a pool state log at timeout failure. Synchronization fixes. Minor cleanup and javadoc. Refactored SpecializedConcurrentBag for efficiency, moved to util. Initialize the concurrent bag with an initial size. Cache the hashCode. Merged changed from fwbrasil Add license header and class-level javadoc. Even more detailed log for broken connections New concurrent connection container (moved away from LinkedBlockingQueue and LinkedTransferQueue). Adjust version number in the benchmark script. fix fast statement list overflow inconsistency Start of experimental implementation of a concurrent bag. Readability improvement. Added logging for broken connections. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fast statement list returns nulls during iteration when there was a overflow. The effect is a NPE when closing a connection with more open statements than the fast list initial capacity.