Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging bug in HikariMBeanElf.java #51

Closed
mdagit opened this issue Mar 29, 2014 · 1 comment
Closed

logging bug in HikariMBeanElf.java #51

mdagit opened this issue Mar 29, 2014 · 1 comment
Labels
bug

Comments

@mdagit
Copy link

mdagit commented Mar 29, 2014

in HikariMBeanElf.java there is line:
LOGGER.error("No registered MBean for {0}.", configuration.getPoolName());

but slf4j doesn't work that way. it should just be {}.
the message i'm seeing in logs is:
No registered MBean for {0}.
@brettwooldridge
Copy link
Owner

Good catch. That's what I get for coding in two languages at the same time.

brettwooldridge added a commit that referenced this issue Mar 29, 2014
@brettwooldridge
Fixed #51 fix logging string substitution parameter.
cf2f0b0
brettwooldridge added a commit that referenced this issue Mar 30, 2014
@brettwooldridge
Merge branch 'dev'
e3e913c 
* dev:
  Updated change log
  Restore max lifetime check to getConnection() rather than only in the housekeeper thread.  An extremely active pool may never find an idle connection in the housekeeper alone.
  Restore max lifetime check to getConnection() rather than only in the housekeeper thread.  An extremely active pool may never find an idle connection in the housekeeper alone.
  Fixed #51 fix logging string substitution parameter.
  Switch back to setting our own context class loader during code generation.
  Change visibility.
@simran66 simran66 mentioned this issue Apr 26, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brettwooldridge @mdagit