Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool leaks connections open if customization/initSql fails #44

Closed
TuomasKiviaho opened this issue Mar 19, 2014 · 0 comments
Closed

Pool leaks connections open if customization/initSql fails #44

TuomasKiviaho opened this issue Mar 19, 2014 · 0 comments
Labels

Comments

@TuomasKiviaho
Copy link

There seems to be slight a possibility to connection leak in the pool between acquiring a connection and adding it to the pool. Connection state reset has similar problem as well.

Steps to fix the issue (HikariPool.addConnection):

  1. Obtaining of a datasource connection should be closed (try/catch) in case of a failure prior it has been added to the pool
  2. initSql block should be followed by resetConnectionState in any case (try/finally)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants