Possible Race Condition on Shutdown

[dharrigan]

Hi,

Continuing on from the forums, thought I might as well open an issue for tracking purposes.

I'm seeing this now and again when I shutdown (ctrl+c) my Spring application (using HikariCP as the datasource provider):

[2014-07-30 18:06:55.004][               ][DEVELOPMENT][WARN ][com.zaxxer.hikari.pool.HikariPool       ][279 ] - Internal accounting inconsistency, totalConnections=-2
java.lang.Exception: null
    at com.zaxxer.hikari.pool.HikariPool.closeConnection(HikariPool.java:279) [HikariCP-2.0.1.jar:na]
    at com.zaxxer.hikari.pool.HikariPool.releaseConnection(HikariPool.java:221) [HikariCP-2.0.1.jar:na]
    at com.zaxxer.hikari.proxy.ConnectionProxy.close(ConnectionProxy.java:343) [HikariCP-2.0.1.jar:na]
    at com.zaxxer.hikari.util.PoolUtilities.quietlyCloseConnection(PoolUtilities.java:18) [HikariCP-2.0.1.jar:na]
    at com.zaxxer.hikari.pool.HikariPool.lambda$abortActiveConnections$5(HikariPool.java:478) [HikariCP-2.0.1.jar:na]
    at com.zaxxer.hikari.pool.HikariPool$$Lambda$63/633170599.accept(Unknown Source) [HikariCP-2.0.1.jar:na]
    at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183) [na:1.8.0_11]
    at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1359) [na:1.8.0_11]
    at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:512) [na:1.8.0_11]
    at java.util.stream.ForEachOps$ForEachTask.compute(ForEachOps.java:290) [na:1.8.0_11]
    at java.util.concurrent.CountedCompleter.exec(CountedCompleter.java:731) [na:1.8.0_11]
    at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) [na:1.8.0_11]
    at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:902) [na:1.8.0_11]
    at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1689) [na:1.8.0_11]
    at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1644) [na:1.8.0_11]
    at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157) [na:1.8.0_11]
[2014-07-30 18:06:55.007][               ][DEVELOPMENT][INFO ][o.s.s.concurrent.ThreadPoolTaskScheduler][203 ] - Shutting down ExecutorService 'taskScheduler'

Comments from Brett suggest that this could be a race condition.

https://groups.google.com/forum/?hl=en-GB#!topic/hikari-cp/Dfpn8iaZxkA

-=david=-

[brettwooldridge]

It wasn't a race condition, merely an accounting issue decrementing the totalConnections count when aborting connections. This fix will be in the next release of HikariCP. It is available now on the dev branch.

[dharrigan]

Thank you :-)

-=david=-

On 31 July 2014 06:07, Brett Wooldridge [email protected] wrote:

It wasn't a race condition, merely an accounting issue decrementing the
totalConnections count when aborting connections. This fix will be in the
next release of HikariCP. It is available now on the dev branch.

—
Reply to this email directly or view it on GitHub
#128 (comment)
.

I prefer encrypted and signed messages. KeyID: B20A22F9
Fingerprint: 110A F423 3647 54E2 880F ADAD 1C52 85BF B20A 22F9

"It is not usually until you've built and used a version of the program
that you understand the issues well enough to get the design right." - Rob
Pike, Brian Kernighan.

No trees were harmed in the sending of this message, however, a number of
electrons were inconvenienced.