minimumIdle=0 means no limit?

[djj0809]

I just want to obtain HikariDataSource with no connections initially as backup datasources, but I found that it still reach maximumPoolSize after a while when I never invoke getConnection() on this dataSource.
Then I found this piece of code:

   @Override
   public void addBagItem()
   {
      class AddConnection implements Runnable
      {
         public void run()
         {
            long sleepBackoff = 200L;
            final int maxPoolSize = configuration.getMaximumPoolSize();
            final int minIdle = configuration.getMinimumIdle();
            while (!isShutdown && totalConnections.get() < maxPoolSize && (minIdle == 0 || getIdleConnections() < minIdle)) {  
               if (!addConnection()) {
                  quietlySleep(sleepBackoff);
                  sleepBackoff = Math.min(1000L, (long) ((double) sleepBackoff * 1.5));
                  continue;
               }

               if (minIdle == 0) {
                  break; // This break is here so we only add one connection when there is no min. idle
               }
            }
         }
      }

      addConnectionExecutor.submit(new AddConnection());
   }

It seems the house keeper thread create one connection each time when minIdle==0, until reach maxPoolSize...

I am wondering why doing things like that? Can we just do nothing when minIdle==0?

[brettwooldridge]

It is a bug.

[djj0809]

I will appreciate it if you can fix it soon:)

[brettwooldridge]

This is fixed in the dev branch. You will need to build it if you need it before the next release. See the build instructions here.

[djj0809]

Thanks!