Add initial implementation of BLE key pairing #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natekspencer
requested changes
Sep 18, 2023
1) Remove use of global variables 2) Add typing 3) Remove scan_for_device() and require callers to pass in a bleak BLEDevice 4) Open bleak client by device (not by address) 5) Remove retry from pairing function and return status of pairing 6) Check that returned vehicle id matches expected (address todo)
|
All feedback should be addressed |
natekspencer
requested changes
Sep 19, 2023
1) general cleanup 2) handle notifications for separately per characteristic to avoid possible mixup 3) add notification timeouts 4) log exceptions
|
Addressed |
natekspencer
requested changes
Sep 27, 2023
|
Feedback addressed |
natekspencer
approved these changes
Oct 11, 2023
natekspencer
pushed a commit
that referenced
this pull request
Oct 11, 2023
natekspencer
pushed a commit
that referenced
this pull request
Oct 11, 2023
natekspencer
pushed a commit
that referenced
this pull request
Oct 11, 2023
1) Remove use of global variables 2) Add typing 3) Remove scan_for_device() and require callers to pass in a bleak BLEDevice 4) Open bleak client by device (not by address) 5) Remove retry from pairing function and return status of pairing 6) Check that returned vehicle id matches expected (address todo)
natekspencer
pushed a commit
that referenced
this pull request
Oct 11, 2023
1) general cleanup 2) handle notifications for separately per characteristic to avoid possible mixup 3) add notification timeouts 4) log exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.