Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecations to connection fields #68

Conversation

thebadmonkeydev
Copy link
Contributor

Problem

Connection field descriptions are not parsed for markdown and deprecation notices aren't rendered for this particular field type.

Solution

I used similar HTML as found in graphql-docs/lib/graphql-docs/layouts/includes/fields.html for rendering deprecation notices and wrapped connection[:description] in markdownify.()

@gjtorikian gjtorikian merged commit b11e9aa into brettchalupa:master Mar 4, 2019
@gjtorikian
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants