Pass filename through to HTML pipeline #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests pass again after rebasing on your most recent PR. 👍 |
|
This looks great. Thank you so much. |
|
Thanks for considering it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I can achieve #51 (relative hrefs) through a mixture of a custom html-pipeline filter and some code in some custom layouts. However, in order to do so I need to know the filename that the file is being written to. This allows me to determine the 'depth' relative to some base path of the current file, and therefore add the right number of
../entries to get out of there.This pull request passes the filename through to the pipeline's context (on a per-file basis rather than the overarching pipeline-wide context).
Fixes #51.