feat(parser): add deprecation information for field arguments #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like fields have deprecation information, add deprecation information for field arguments as well. This is useful information that has been missing so far from the parser. It can be used by custom templates that display deprecated arguments differently, such as showing a warning or hiding the deprecated argument altogether. The implementation follows the same logic as `field` a few lines above.
brettchalupa
requested changes
Mar 9, 2023
|
Also, I see the Ruby 2.6.10 tests are failing, but that looks to be unrelated to your changes. I'll work on fixing that in |
|
@jeromedalbert thanks again for the contribution! I'll cut a 4.1 release early next week with the change. |
|
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like fields have deprecation information, add deprecation information for field arguments as well.
This is useful information that has been missing so far from the parser. It can be used by custom templates that display deprecated arguments differently, such as showing a warning or hiding the deprecated argument altogether.
The implementation follows the same logic as
fielda few lines above.