Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File naming rule added #90

Closed
wants to merge 3 commits into from

Conversation

huseyinbabal
Copy link
Contributor

  • file_name_rule option added to apply conversion in more generic way
  • required tests written
  • README updated

@huseyinbabal
Copy link
Contributor Author

Closes #91

- Conversion function improvement
@calvn
Copy link
Contributor

calvn commented Aug 16, 2016

This is an interesting feature, but I don't think we will be merging this one.

There are cases where passing in functions or commands as part of the configuration file makes sense (e.g. Sensu checks). However, for git2consul this doesn't feel quite right, and opens up a lot of possibilities to break the program, malicious actors to execute arbitrary commands, or any other unintended side effects to occur, since calls are now not contained within the source.

Additionally, as mentioned in #86, git2consul has been falling into the the land of configuration hell as more and more flags were added recently. We are trying to tune down on this by not accepting any and all feature requests, as we have in the past.

We would like to keep git2consul as lean as possible, and as close to the scope of simply uploading files to the KV as we can. Perhaps file manipulation could be handled separately by another program before it gets processed/read by git2consul. Nevertheless, we appreciate your contribution and thank you for pitching in to ideas to improve git2consul!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants