feat: use with_connection where possible
#441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rails/rails#51349 - this allows rails 7.2 applications to raise an error or emit a deprecation warning whenever `ActiveRecord::Base.connection` is used. this makes sure that in rails 7.1 and after we use the new, preferred method.
flood4life
force-pushed
the
with_connection
branch
from
965b3b1 to
018b4f3
Compare
|
This is good :D Thank you for the hard work. I've also applied it to the |
|
Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rails/rails#51349 - this allows rails 7.2 applications to raise an error or emit a deprecation warning whenever
ActiveRecord::Base.connectionis used.The PR makes sure that in Rails 7.1 and after we use the new, preferred method of obtaining a connection.