Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use radius when mapping back to the sphere #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stes
Copy link
Collaborator

@stes stes commented Nov 18, 2022

Unless I am overlooking something, the spherical space is currently not mapped back to the radius self.r when sampling from any of the existing distributions. I moved the normalization into its own function, and added the rescaling to self.r.

@stes stes requested a review from zimmerrol November 18, 2022 13:49
@stes stes self-assigned this Nov 18, 2022
@zimmerrol
Copy link
Collaborator

Thanks for fixing this. Do you mind adding a docstring to the normalize function and adapting the von_mises_fisher function as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants