Add generic Rhs parameter for traits and structs and generalize implementations for [T] #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes them match `std::cmp::PartialEq`. It's also necessary to make it possible to implement the `*Eq` traits for some combinations of types, such as `ndarray::ArrayBase<S, D>` instances of differing storage `S` (e.g. owned and view).
jturner314
force-pushed
the
generic-rhs
branch
from
545db1d to
09b679c
Compare
This is necessary for the macros to function correctly when the left and right hand sides have different types.
|
I just realized that I needed to update the structs too ( |
jturner314
changed the title
|
Ohh, this is a very nice change! Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a
Rhsparameter makes them matchstd::cmp::PartialEq. It's also necessary to make it possible to implement the*Eqtraits for some combinations of types, such asndarray::ArrayBase<S, D>instances of differing storageS(e.g. owned and view). (See the implementation ofPartialEqforArrayBasefor an example.)This PR also implements
*Eq<[B]> for [A], analogous to thisPartialEqimplementation.As far as I can tell, this is a backwards compatible change since it retains
Selfas the default forRhs.