Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows update to 5.27.2015 master branch #36

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Windows update to 5.27.2015 master branch #36

wants to merge 9 commits into from

Conversation

yogurt-island-331
Copy link

No description provided.

@brendano
Copy link
Owner

what's the intended input to runString()?
is it intended for just one tweet? or many tweets?
it looks like it only gets one tweet worth of output.
that's not acceptable -- it's really wasteful to re-start the tagger for every tweet!
also the script will break on filenames with spaces in them.

@yogurt-island-331
Copy link
Author

@brendano thank you so much for testing the package and giving me feedback. The intended input to runString() is just a string. It's meant for just one tweet. I completely agree with you that this is wasteful and I don't recommend using this for actually running the tagger on a lot of tweets. This is meant to help the user test if the package is working with one sentence, and then the user can do the bulk tagging if the packages is working for one sentence... I will edit the script to warn user about this. I will fix the filename issue today :-)

now when you run runFile method, you will get a result file looks like this 'tagged_tweets_xxx.txt', the 'xxx' part could be any number, it's just a random number generated by the system. Go to this file, you will see all your tweets tagged. This new commit also will work if your file name has space...
@yogurt-island-331
Copy link
Author

@brendano just fixed the code and added a file output to the runFile method. Let me know if this doesn't work for you again and I can reopen this issue, but will close it for now... thanks again!

@brendano
Copy link
Owner

i'm not using it anyways, i just wanted it to be more robust and ready to be useful before merging it.

@yogurt-island-331
Copy link
Author

Hi Breandan, could you merge my branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants