Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong type for Gogol.BigQuery.jclQuote #52

Closed
lorenzo opened this issue Dec 19, 2016 · 2 comments
Closed

Wrong type for Gogol.BigQuery.jclQuote #52

lorenzo opened this issue Dec 19, 2016 · 2 comments
Assignees
@brendanhay
Labels
bug

Comments

@lorenzo
Copy link

lorenzo commented Dec 19, 2016

The jclQuote lens should actually be optional. Currently it is a required text, but it should have been Maybe Text.

The consequence of the current implementation is that it is impossible to process a JSON payload without getting an error about this field. The error is:

Only CSV imports may specify a quote character

Setting jclQuote to an empty Text has no effect on the error.
@brendanhay brendanhay self-assigned this Dec 19, 2016
@brendanhay brendanhay added the bug label Dec 19, 2016
@brendanhay
Copy link
Owner

That's rather unfortunate, the specification gives it a default value of \". I'll add an override to make it optional and regenerate gogol-bigquery.

brendanhay added a commit that referenced this issue Feb 12, 2017
@brendanhay
Ensuring JobConfigurationLoad.quote is marked as optional
83f0555 
See #52 and the error 'Only CSV imports may specify a quote character'
@brendanhay
Copy link
Owner

Fixed in 83f0555, which is now in develop.

donatello pushed a commit to donatello/gogol that referenced this issue Jul 16, 2018
@brendanhay @donatello
Ensuring JobConfigurationLoad.quote is marked as optional
90165c3 
See brendanhay#52 and the error 'Only CSV imports may specify a quote character'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brendanhay brendanhay

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brendanhay @lorenzo