Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paying onchain doesn't show error #277

Closed
roeierez opened this issue Dec 17, 2024 · 0 comments · Fixed by #365
Closed

Paying onchain doesn't show error #277

roeierez opened this issue Dec 17, 2024 · 0 comments · Fixed by #365
Assignees
@erdemyerebasmaz
Labels
High Priority
Milestone
Release Misty Bre...

Comments

@roeierez
Copy link
Member

When paying on chain returns error the UI form is popped and no error is shown to the user.
@erdemyerebasmaz erdemyerebasmaz self-assigned this Jan 7, 2025
erdemyerebasmaz added a commit that referenced this issue Feb 10, 2025
@erdemyerebasmaz
fix: pop loader route only if it's active on errors
f2425e5 
Fixes #277
@erdemyerebasmaz erdemyerebasmaz mentioned this issue Feb 10, 2025
Merged
erdemyerebasmaz added a commit that referenced this issue Feb 10, 2025
@erdemyerebasmaz
Fix UI regression preventing on-chain payment errors from showing
378bf57 
Fixes #277

- Add option to prompt error if payment fails while showing ProcessingPaymentSheet
- Add option to pop to Home on completing payment while showing ProcessingPaymentSheet
- Pop loader route at all times & only if it's active
erdemyerebasmaz added a commit that referenced this issue Feb 12, 2025
@erdemyerebasmaz
Fix UI regression preventing on-chain payment errors from showing (#365)
0fca1ad 
Fixes #277

- Add option to prompt error if payment fails while showing ProcessingPaymentSheet
- Add option to pop to Home on completing payment while showing ProcessingPaymentSheet
- Pop loader route at all times & only if it's active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erdemyerebasmaz erdemyerebasmaz

Labels
High Priority
Projects
None yet
Milestone
Release Misty Breez on app stores
Development

Successfully merging a pull request may close this issue.

Fix UI regression preventing on-chain payment errors from showing breez/misty-breez
2 participants
@erdemyerebasmaz @roeierez