BIP353 address parser #619
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hydra-yse
requested changes
Dec 19, 2024
There was a problem hiding this comment.
Hey @lorenzoronzani, thanks for contributing! I've left two small comments, but besides that the code is looking good. It'd be better if this parsing method was shared so we can also reuse it on the Greenlight SDK.
hydra-yse
requested changes
Dec 19, 2024
|
I tried to resolve all of your comment in the breez-sdk-greenlight repo inside the following PR breez/breez-sdk-greenlight#1149. I think this PR could be keep active because it requires some code that it is implemented inside the other one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: I implemented within the sdk the function to parse a BIP353 address and extract the corresponding bolt12 or lnurl-pay offer. To achieve that I needed a dns-resolver and I decided to use trust-dns-resolver crate.
feat: I edited the cli accepted inputs to be able to understand also a pay_code.
The idea behind my implementation is to use the already provided section regarding the final payment adding before that a parser layer to intercept BIP353 addresses and resolve it.