Expo Plugin

[larcho]

This extension in the React Native Module would add the Expo Plugin for automating adding the Notification Service to the app. This would safe all the "native" effort required for setting it up. Also, this does not interfere with non Expo projects, since the plugin gets added in Expo specific configurations (app.plugin.js).

Personally I don't like doing huge PRs and would do the Android bit in a separate PR. This should be safe to merge and shouldn't affect current Vanilla React Native implementation.

[dangeross]

This is really cool @larcho! I have to figure out how to test this.

[larcho]

This is really cool @larcho! I have to figure out how to test this.

Maybe I can set something up like the already existing example for bare react native.

[larcho]

@dangeross I added a example-expo project as you might have noticed. It also has a script called prebuild:ios that builds the ios folder with the XCodeProject, adding the target as well.

I'm not able to currently build it though, since there's something weird going on with the LiquidMapper file on my end. (I'm using yarn link to use the local version).

[larcho]

@dangeross I added a example-expo project as you might have noticed. It also has a script called prebuild:ios that builds the ios folder with the XCodeProject, adding the target as well.

I'm not able to currently build it though, since there's something weird going on with the LiquidMapper file on my end. (I'm using yarn link to use the local version).

It's able to resolve AesSuccessActionData

[larcho]

@dangeross I added a example-expo project as you might have noticed. It also has a script called prebuild:ios that builds the ios folder with the XCodeProject, adding the target as well.
I'm not able to currently build it though, since there's something weird going on with the LiquidMapper file on my end. (I'm using yarn link to use the local version).

It's able to resolve AesSuccessActionData

@dangeross I spotted the issue, maybe you can hint me how you deal with versions in the SDK. If you currently look at the main branch you'll notice that the version for the package is 0.4.0-rc3, which also pulls the BreezSDKLiquid for that version. That required Pod though does not have the struct AesSuccessActionData yet which causes my build to fail.

I think struct AesSuccessActionData is something from version 0.5.0 right?

[dangeross]

I think struct AesSuccessActionData is something from version 0.5.0 right?

@larcho Yes it was added from 0.5.0-rc1

I think this is just a local testing issue. You can bump the react-native/package.json version up to 0.5.0-rc4

[larcho]

I think struct AesSuccessActionData is something from version 0.5.0 right?

@larcho Yes it was added from 0.5.0-rc1

I think this is just a local testing issue. You can bump the react-native/package.json version up to 0.5.0-rc4

Adjusting the the package version solved the problem.

[dangeross]

I'm getting this error running yarn ios, I ran yarn in react-nativeandreact-naive/example-expo` first:

Error: Cannot find module './plugin/build'

Am I missing a step?

[larcho]

I'm getting this error running yarn ios, I ran yarn in react-nativeandreact-naive/example-expo` first:

Error: Cannot find module './plugin/build'

Am I missing a step?

yup yarn plugin:build Which I think can be attached during npm publishing. You'll also notice in the example project I'm linking the library using file: which we might not want but during development it might be easier to use.

[dangeross]

yup yarn plugin:build Which I think can be attached during npm publishing. You'll also notice in the example project I'm linking the library using file: which we might not want but during development it might be easier to use.

It would be good to add the yarn plugin:build to the prepare script, but it looks like it watches for changes. Do you know a way to not watch?

[larcho]

yup yarn plugin:build Which I think can be attached during npm publishing. You'll also notice in the example project I'm linking the library using file: which we might not want but during development it might be easier to use.

It would be good to add the yarn plugin:build to the prepare script, but it looks like it watches for changes. Do you know a way to not watch?

Yup, it's possible do that without "watching" (weird approach from the plugin package). I'll update and include it to the prepare script.

[larcho]

yup yarn plugin:build Which I think can be attached during npm publishing. You'll also notice in the example project I'm linking the library using file: which we might not want but during development it might be easier to use.

It would be good to add the yarn plugin:build to the prepare script, but it looks like it watches for changes. Do you know a way to not watch?

Yup, it's possible do that without "watching" (weird approach from the plugin package). I'll update and include it to the prepare script.

fixed