Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename breez/breez-sdk to breez/breez-sdk-greenlight #179

Merged
merged 4 commits into from
Sep 30, 2024
Merged

rename breez/breez-sdk to breez/breez-sdk-greenlight #179

merged 4 commits into from
Sep 30, 2024

Conversation

JssDWt
Copy link
Contributor

@JssDWt JssDWt commented Sep 23, 2024

No description provided.

@JssDWt JssDWt marked this pull request as ready for review September 30, 2024 12:59
@JssDWt JssDWt force-pushed the jssdwt-breez-sdk-greenlight branch from 7e9c688 to bab7bce Compare September 30, 2024 13:01
@JssDWt JssDWt requested review from dangeross and ok300 September 30, 2024 13:44
@JssDWt
Copy link
Contributor Author

JssDWt commented Sep 30, 2024

@dangeross @ok300 Can you check the remaining 3 commits?

ok300
ok300 reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@ok300 ok300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version (0.5.0) is set in a bunch of other files, so the new version has to be updated in them too:

  • src/guide/install.md L96
  • snippets/dart_snippets/pubspec.lock L58
  • snippets/kotlin_mpp_lib/shared/build.gradle.kts L37
  • snippets/swift/BreezSDKExamples/Package.resolved L8-9
  • snippets/swift/BreezSDKExamples/Package.swift L11
  • snippets/rust/Cargo.toml L9 (best to just set the tag, if you don't need a custom rev)
  • snippets/rust/Cargo.lock (running cargo clippy will update the right lines)

.github/workflows/main.yml Outdated Show resolved Hide resolved
@JssDWt JssDWt force-pushed the jssdwt-breez-sdk-greenlight branch from 9f801cf to 4c7a87d Compare September 30, 2024 18:57
dangeross
dangeross approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JssDWt JssDWt merged commit 4c7a87d into main Sep 30, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ok300 ok300 ok300 left review comments

@dangeross dangeross dangeross approved these changes

@yaslama yaslama yaslama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JssDWt @yaslama @dangeross @ok300