Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Swift CI warnings #126

Merged
merged 13 commits into from
Jan 31, 2024
Merged

Fix Swift CI warnings #126

merged 13 commits into from
Jan 31, 2024

Conversation

ok300
Copy link
Contributor

@ok300 ok300 commented Jan 20, 2024 •
edited
Loading

This PR bumps the SDK dependency of all snippets from 0.2.10 to 0.2.15.

This PR fixes the Swift CI warnings

The remaining errors will be solved by a new published version of breez-sdk-swift as described here.

@ok300
Copy link
Contributor Author

ok300 commented Jan 20, 2024

I'm not yet sure why the Swift CI is failing. The logs have warnings like

warning: object file ... was built for newer macOS version (13.0) than being linked (12.0)

which is probably because breez-sdk-swift is built with macos-13 but the snippets are using macos-12.

But this hasn't changed since 0.2.10 so it can't be the reason it fails.

@dangeross @ubbabeck any idea what is missing for the Swift CI to pass?

@ok300 ok300 changed the title Bump breez-sdk snippet dependency to 0.2.12 Bump breez-sdk snippet dependency to 0.2.14 Jan 23, 2024
@ok300 ok300 mentioned this pull request Jan 24, 2024
Merged
@erdemyerebasmaz
Fix linter warnings for Swift snippets
f881f0a
@erdemyerebasmaz
Explicitly set Swift version
57a3d9a 
Not doing so will resolve the version it's latest minor and patch version.
In this case, 5.9.2 which is incompatible with the runner.
@hydra-yse hydra-yse mentioned this pull request Jan 25, 2024
Merged
@ok300 ok300 force-pushed the ok300-bump-sdk-dependency-version branch from 5e6beb3 to 9fe8ce6 Compare January 27, 2024 00:20
@ok300 ok300 force-pushed the ok300-bump-sdk-dependency-version branch from 9fe8ce6 to 63b4c36 Compare January 27, 2024 00:29
@ok300
Copy link
Contributor Author

ok300 commented Jan 27, 2024

I think the reason pointing to an SDK commit doesn't work for Swift, is because the 0.2.14 Swift bindings are downloaded and used:

Downloading binary artifact https://github.com/breez/breez-sdk-swift/releases/download/0.2.14/breez_sdkFFI.xcframework.zip
[15149/317738527] Downloading https://github.com/breez/breez-sdk-swift/releases/download/0.2.14/breez_sdkFFI.xcframework.zip
Downloaded https://github.com/breez/breez-sdk-swift/releases/download/0.2.14/breez_sdkFFI.xcframework.zip (22.30s)

So any changes in the SDK dependency tree is not reflected in the Swift bindings used by the CI here.

However I tried to run swift build locally, adjusting it to point to the local Swift bindings (generated with make bindings-swift on breez/breez-sdk-greenlight#757), as described by @ubbabeck in 20576b6, and I got

...
[24/24] Linking BreezSDKDocs
Build complete! (3.11s)

So, unless I made any mistakes above, it looks like this CI step will only work after the next release, when breez-sdk-swift will contain binaries generated from a breez-sdk that includes breez/breez-sdk-greenlight#757.

@ok300
Merge branch 'main' into ok300-bump-sdk-dependency-version
cb2d3d6 
# Conflicts:
#	.github/workflows/main.yml
#	snippets/go/go.mod
#	snippets/kotlin_mpp_lib/shared/build.gradle.kts
#	snippets/python/src/send_spontaneous_payment.py
#	snippets/react-native/yarn.lock
#	snippets/rust/Cargo.lock
#	snippets/rust/Cargo.toml
#	snippets/swift/BreezSDKExamples/Package.resolved
#	snippets/swift/BreezSDKExamples/Package.swift
#	src/guide/install.md
@ok300 ok300 changed the title Bump breez-sdk snippet dependency to 0.2.14 Bump breez-sdk snippet dependency to 0.2.15 Jan 30, 2024
@ok300
Copy link
Contributor Author

ok300 commented Jan 30, 2024

The actual bumping to 0.2.15 already happened and was merged in main as part of a previous PR.

This PR only gets rid of a few warnings in Swift and updates the pubspec.lock.

@ok300 ok300 changed the title Bump breez-sdk snippet dependency to 0.2.15 Fix Swift CI warnings Jan 31, 2024
JssDWt
JssDWt approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@JssDWt JssDWt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ok300 ok300 merged commit a3339b9 into main Jan 31, 2024
58 of 59 checks passed
@ok300 ok300 deleted the ok300-bump-sdk-dependency-version branch March 16, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JssDWt JssDWt JssDWt approved these changes

@erdemyerebasmaz erdemyerebasmaz Awaiting requested review from erdemyerebasmaz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ok300 @JssDWt @erdemyerebasmaz