Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS strings for Satscard integration #28

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

PeteClubSeven
Copy link
Contributor

I added the test for the one new string which uses a placeholder.

The differences from Android:

  • A "Sweep Satscard" option was added to the receive actions on the bottom action bar
    • This opens the NFC system prompt for iOS
    • A success or error message is shown on the NFC system prompt when scanning a Satscard on the home page
  • A placeholder retry message is all that is required for SatscardOperationDialog on iOS
  • Messages that are presented by SatscardOperationDialog on Android are instead routed through the NFC system prompt for iOS
    • On Android we present a progress indicator along with the waiting text but we can't on iOS so we include the progress in the text itself as a percentage

Copy link
Collaborator

@ademar111190 ademar111190 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect; thank you very much

@ademar111190 ademar111190 merged commit db22dd2 into breez:main Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants