add timezone support #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@knicola Let me know if you need any help with this. If you want, I have some time later today to help fix up some of those unrelated tests that are failing. |
|
@shadowgate15 If you could have a look that'd be great. The build seems to be timing out right before the coverage report. I know I forgot to cleanup a sinon spy so I'll take care of that one in a bit. |
|
I'm going to go ahead and merge this. the issue is a timing related thing, which just makes it a little flaky. thank you for all your hard work!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moving timezone support from breejs/bree#126 to
breejs/laterChangelog
Added:
.setTimeout()and.setInterval()sinon@^11.1.2as a dev dependency