-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issue #74 use local timezone #76
Merged
shadowgate15
merged 6 commits into
breejs:master
from
snrmwg:issue/74-use-local-timezone
Feb 5, 2021
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5d56016
fix: issue #74 use local timezone
snrmwg 6cb24bd
fix: updated travisCI config: use Focal dist and include node 14
snrmwg c669884
fix: reverted travisCI config and refined test
snrmwg b6b96a5
fix: refined test
snrmwg ebb2ae3
fix: refactoring and improved test
snrmwg a95c5b0
Merge branch 'master' into issue/74-use-local-timezone
snrmwg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's change this to the timezone offset instead, so that we are testing explicitly what we want instead of an after effect. you should be able to use
now.getTimezoneOffset()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
now.getTimezoneOffset()
makes assertion unnecessary complex. Because then the result will depend on the timezone the test is executed. For my local system for example (CET) the result would be-60
.The check on
now.getHours()
simply checks the wanted effect: the cron pattern says "do it at 18:00 o'clock". So when the job gets executed, the hour of now is expected to be 18. Independent of timezone.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
want to be testing the actual offset not just what the hours say.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I added the offset check in the tests.