feat: omit job env in workerData (fixes #171)

src/index.js

@@ -25,6 +25,12 @@ const {
 const buildJob = require('./job-builder');
 const validateJob = require('./job-validator');
 
+function omit(obj, props) {
+  obj = { ...obj };
+  for (const prop of props) delete obj[prop];
+  return obj;
+}
+
 const debug = debuglog('bree');
 
 class ImportError extends Error {}
@@ -361,7 +367,10 @@ class Bree extends EventEmitter {
         ...(this.config.worker ? this.config.worker : {}),
         ...(job.worker ? job.worker : {}),
         workerData: {
-          job,
+          job: {
+            ...job,
+            ...(job.worker ? { worker: omit(job.worker, ['env']) } : {})
+          },
           ...(this.config.worker && this.config.worker.workerData
             ? this.config.worker.workerData
             : {}),

test/issues/issue-171.js

@@ -0,0 +1,45 @@
+const path = require('path');
+const { SHARE_ENV } = require('worker_threads');
+
+const test = require('ava');
+
+const Bree = require('../../src');
+
+const root = path.join(__dirname, '../jobs');
+
+test('works with SHARE_ENV using top-level', async (t) => {
+  const bree = new Bree({
+    root,
+    worker: {
+      env: SHARE_ENV
+    },
+    jobs: [{ name: 'long', closeWorkerAfterMs: 2000 }]
+  });
+
+  await t.notThrowsAsync(bree.run('long'));
+});
+
+test('works with SHARE_ENV using job-specific', async (t) => {
+  const bree = new Bree({
+    root,
+    jobs: [
+      { name: 'long', closeWorkerAfterMs: 2000, worker: { env: SHARE_ENV } }
+    ]
+  });
+
+  await t.notThrowsAsync(bree.run('long'));
+});
+
+test('works with SHARE_ENV using both', async (t) => {
+  const bree = new Bree({
+    root,
+    worker: {
+      env: SHARE_ENV
+    },
+    jobs: [
+      { name: 'long', closeWorkerAfterMs: 2000, worker: { env: SHARE_ENV } }
+    ]
+  });
+
+  await t.notThrowsAsync(bree.run('long'));
+});