This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Add Autofill support #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| base::FilePath user_dir; | ||
| PathService::Get(brightray::DIR_USER_DATA, &user_dir); | ||
| CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); | ||
| web_database_ = new WebDatabaseService(user_dir.Append(kWebDataFilename), |
There was a problem hiding this comment.
this path should have the partition name in it to avoid access from more than one browser context
|
Thanks for the feedback. Changed has made in 615a937954aa37194e9abec4b7a534f70e5d819b. |
|
This doesn't apply or cherry-pick in cleanly to master. Could you pls rebase? Thanks! |
|
++ I'm going to make a few small organizational tweaks to split this out from electron and then I'll merge |
fix brave/browser-laptop#860 auditor: @bridiver, @bbondy
|
@bbondy is this still an open issue? I thought you mentioned a fix/workaround? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/browser-laptop#860
auditor: @bridiver, @bbondy