This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Add more detail attributes for certificate-error #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this patch is need, I will add this new interface to document files on the next commit. |
|
please also upstream this to electron/electron |
|
++ thank you |
| @@ -46,6 +46,12 @@ v8::Local<v8::Value> Converter<scoped_refptr<net::X509Certificate>>::ToV8( | |||
| encoded_data.size()).ToLocalChecked(); | |||
| dict.Set("data", buffer); | |||
| dict.Set("issuerName", val->issuer().GetDisplayName()); | |||
| dict.Set("subjectName", val->subject().GetDisplayName()); | |||
| dict.Set("serialNum", val->serial_number()); | |||
There was a problem hiding this comment.
this looks good, but any special reason we are abbreviating this? If it matches up to something else that's great, but otherwise it seems like it could lead to unexpected null results
There was a problem hiding this comment.
Agreed. It would be better if we change it to serialNumber
bridiver
force-pushed
the
master
branch
2 times, most recently
from
2290673 to
15566f6
Compare
3 tasks
|
thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for brave/browser-laptop#2428
CC @bbondy @diracdeltas