Pass by reference in autofill API

Auditors: @bbondy
brave · Sep 8, 2016 · 50afdf1 · 50afdf1 · bbondy · Sep 8, 2016
1 parent 3c63fc2
commit 50afdf1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/atom/browser/api/atom_api_autofill.cc b/atom/browser/api/atom_api_autofill.cc
@@ -251,7 +251,7 @@ std::string Autofill::AddProfile(const base::DictionaryValue& profile) {
   return personal_data->SaveImportedProfile(autofill_profile);
 }
 
-autofill::AutofillProfile* Autofill::GetProfile(std::string guid) {
+autofill::AutofillProfile* Autofill::GetProfile(const std::string& guid) {
   autofill::PersonalDataManager* personal_data =
       autofill::PersonalDataManagerFactory::GetForBrowserContext(
       browser_context_);
@@ -263,7 +263,7 @@ autofill::AutofillProfile* Autofill::GetProfile(std::string guid) {
   return personal_data->GetProfileByGUID(guid);
 }
 
-bool Autofill::RemoveProfile(const std::string guid) {
+bool Autofill::RemoveProfile(const std::string& guid) {
   autofill::PersonalDataManager* personal_data =
       autofill::PersonalDataManagerFactory::GetForBrowserContext(
       browser_context_);
@@ -317,7 +317,7 @@ std::string Autofill::AddCreditCard(const base::DictionaryValue& card) {
   return personal_data->SaveImportedCreditCard(credit_card);
 }
 
-autofill::CreditCard* Autofill::GetCreditCard(std::string guid) {
+autofill::CreditCard* Autofill::GetCreditCard(const std::string& guid) {
   autofill::PersonalDataManager* personal_data =
       autofill::PersonalDataManagerFactory::GetForBrowserContext(
       browser_context_);
@@ -328,7 +328,7 @@ autofill::CreditCard* Autofill::GetCreditCard(std::string guid) {
   return personal_data->GetCreditCardByGUID(guid);
 }
 
-bool Autofill::RemoveCreditCard(const std::string guid) {
+bool Autofill::RemoveCreditCard(const std::string& guid) {
   autofill::PersonalDataManager* personal_data =
       autofill::PersonalDataManagerFactory::GetForBrowserContext(
       browser_context_);

diff --git a/atom/browser/api/atom_api_autofill.h b/atom/browser/api/atom_api_autofill.h
@@ -43,12 +43,12 @@ class Autofill : public mate::TrackableObject<Autofill> {
   ~Autofill() override;
 
   std::string AddProfile(const base::DictionaryValue& profile);
-  autofill::AutofillProfile* GetProfile(std::string guid);
-  bool RemoveProfile(const std::string guid);
+  autofill::AutofillProfile* GetProfile(const std::string& guid);
+  bool RemoveProfile(const std::string& guid);
 
   std::string AddCreditCard(const base::DictionaryValue& card);
-  autofill::CreditCard* GetCreditCard(std::string guid);
-  bool RemoveCreditCard(const std::string guid);
+  autofill::CreditCard* GetCreditCard(const std::string& guid);
+  bool RemoveCreditCard(const std::string& guid);
 
   brave::BraveBrowserContext* browser_context() {
     return static_cast<brave::BraveBrowserContext*>(browser_context_);