Merge pull request #358 from brave/fix/private-session-tabs

Set parent_partition to '' for private session tabs
brave · Oct 25, 2017 · 0aa85d0 · 0aa85d0
2 parents dcd1806 + 4b38d1d
commit 0aa85d0
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/brave/browser/guest_view/tab_view/tab_view_guest.cc b/brave/browser/guest_view/tab_view/tab_view_guest.cc
@@ -254,8 +254,11 @@ void TabViewGuest::CreateWebContents(
     partition_options.SetString("parent_partition", parent_partition);
   } else {
     std::string session_tab_prefix = "persist:partition-";
+    std::string private_tab_prefix = "partition-";
     if (partition.compare(0, session_tab_prefix.length(),
-          session_tab_prefix) == 0) {
+          session_tab_prefix) == 0 ||
+       partition.compare(0, private_tab_prefix.length(),
+          private_tab_prefix) == 0) {
       partition_options.SetString("parent_partition", "");
     }
   }