Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added dnf5 support #41

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Added dnf5 support #41

merged 3 commits into from
Nov 28, 2024

Conversation

wknapik
Copy link
Collaborator

@wknapik wknapik commented Nov 22, 2024 •
edited by mihaiplesa
Loading

@wknapik wknapik self-assigned this Nov 22, 2024
wknapik
wknapik commented Nov 22, 2024
View reviewed changes
install.sh Outdated Show resolved Hide resolved
fmarier
fmarier previously approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously my approval is conditional on the FIXME being updated to a real thing ;)

@wknapik wknapik marked this pull request as ready for review November 27, 2024 17:14
@wknapik
Copy link
Collaborator Author

wknapik commented Nov 27, 2024

This requires https://github.com/brave/devops/pull/12782 to be merged first

@wknapik wknapik requested a review from fmarier November 27, 2024 19:12
fmarier
fmarier approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You tested it with OpenSUSE too, right?

@wknapik
Copy link
Collaborator Author

wknapik commented Nov 27, 2024

Yep

@wknapik wknapik merged commit e14f1f6 into main Nov 28, 2024
3 checks passed
@wknapik wknapik deleted the wknapik-dnf5 branch November 28, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmarier fmarier fmarier approved these changes

Assignees

@wknapik wknapik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wknapik @fmarier